fix: use bounding sphere when bounding box not available #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jesse-small
commented
Jun 1, 2023
•
jesse-small
commented
- getBounds now returns a bounding box from the bounding sphere when a cached bounding box is not available
- calculateError now correctly applies the inverse transform matrix to the bounding sphere before calculating distance
jesse-small
commented
Jun 1, 2023
jesse-small
commented
Jun 1, 2023
src/three/TilesRenderer.js
Outdated
| // Sphere#distanceToPoint is negative inside the sphere, whereas Box3#distanceToPoint is | ||
| // zero inside the box. Clipping the distance to a minimum of zero ensures that both | ||
| // types of bounding volume behave the same way. | ||
| distance = Math.max( boundingSphere.distanceToPoint( tempVector ), 0 ); | ||
| distance = Math.max( tempSphere.distanceToPoint( tempVector ), 0 ); |
There was a problem hiding this comment.
Since we save a transformed bounding sphere this was causing the calculate error to always be wrong for bounding spheres when a transform matrix was present. This applies the inverseTransform to the bounding sphere before calculating the distance.
gkjohnson
reviewed
Jun 2, 2023
|
I added the raycasting logic along with an explanation to this PR #347 |
|
Great thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.