Feature: Draco PNTS proposal alternative #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkjohnson Looks good to me! A bit cleaner than my PNTSFeatureTable refactor. I'll give it a test, and let you know how it goes |
Gmadges
reviewed
May 11, 2023
Gmadges
reviewed
May 11, 2023
Gmadges
suggested changes
May 11, 2023
Thanks! Just made the changes. Can you give it another test to make sure it looks right and then we can get this merged! |
Gmadges
reviewed
May 11, 2023
src/three/PNTSLoader.js
Outdated
| useUniqueIDs: true, | ||
| }; | ||
|
|
||
| const buffer = featureTable.getDracoBuffer( byteOffset, byteLength ); |
There was a problem hiding this comment.
getDracoBuffer -> getBuffer
Gmadges
reviewed
May 11, 2023
src/three/PNTSLoader.js
Outdated
|
|
||
| const buffer = featureTable.getDracoBuffer( byteOffset, byteLength ); | ||
| geometry = await dracoLoader.decodeGeometry( buffer, taskConfig ); | ||
| geometry.copy( dracoGeometry ); |
There was a problem hiding this comment.
This copy isn't required anymore
Gmadges
suggested changes
May 11, 2023
Just made another update. If there are more issues do you mind making a PR into this "draco-pnts-proposal" branch? |
|
@Gmadges Thanks again for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #326
@Gmadges What do you think of this? I've based this off your previous commit and changed it a bit to consolidate all the decoding logic in the PNTS class.
I haven't tested it, though, so I'll need your help with that.