Fix disposal with recursive tilesets (#344)

* Update TilesRendererBase.js * Update TilesRendererBase.js
NASA-AMMOS · Jun 1, 2023 · 9e7048b · 9e7048b
1 parent 9491ab6
commit 9e7048b
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/base/TilesRendererBase.js b/src/base/TilesRendererBase.js
@@ -623,12 +623,15 @@ export class TilesRendererBase {
 
 	dispose() {
 
-		const lruCache = this.lruCache;
-		this.traverse( tile => {
+		// Make sure we've collected all children before disposing of the internal tilesets to avoid
+		// dangling children that we inadvertantly skip when deleting the nested tileset.
+		const toRemove = [];
+		this.traverse( t => toRemove.push( t ) );
+		for ( let i = 0, l = toRemove.length; i < l; i ++ ) {
 
-			lruCache.remove( tile );
+ 			lruCache.remove( toRemove[ i ] );
 
-		} );
+		}
 
 		this.stats = {
 			parsing: 0,