Add body_as_json configuration parameter #712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the user to configure the client to use a Content-Type of application/json for all requests with a body unless the request explicitly provides its own Content-Type header. Using application/json provides a broader range of compatibility with the GitLab API, especially for calls where the body expects more complex data structures. This defaults to false for backwards compatibility.
|
Note that I believe always using application/json by default would be a good change for the next non-backwards-compatible release. I don't believe any part of the GitLab API cannot accept JSON bodies (excepting file uploads requiring multipart form-data, such as https://docs.gitlab.com/api/secure_files/#create-secure-file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to configure the client to use a Content-Type of application/json for all requests with a body unless the request explicitly provides its own Content-Type header.
Using application/json provides a broader range of compatibility with the GitLab API, especially for calls where the body expects more complex data structures.
This defaults to false for backwards compatibility.