fix: discard stale recorder services that never received settings#161
Open
cizra wants to merge 1 commit into
Open
fix: discard stale recorder services that never received settings#161cizra wants to merge 1 commit into
cizra wants to merge 1 commit into
Conversation
After a process crash, Android could restart a recorder service and reconnect the UI to it without the model ever calling init() with the saved settings. The very first access to the `settings` lateinit then threw UninitializedPropertyAccessException, crashing the UI as soon as it bound. Expose `hasInitializedSettings()` on IntervalRecorderService and have BaseRecorderModel detect stale services on bind, drop them, and start a fresh one instead of binding to invalid state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a process crash, Android could restart a recorder service and reconnect the UI to it without the model ever calling init() with the saved settings. The very first access to the
settingslateinit then threw UninitializedPropertyAccessException, crashing the UI as soon as it bound.Expose
hasInitializedSettings()on IntervalRecorderService and have BaseRecorderModel detect stale services on bind, drop them, and start a fresh one instead of binding to invalid state.Code changes by Claude Opus running inside Pi.dev. I built and tested this commit, it works fine in my phone.
Depends on #158 to build and run.