fix: promote recorder services to foreground during init#160
Open
cizra wants to merge 1 commit into
Open
Conversation
Starting a recording could ANR with "Context.startForegroundService() did not then call Service.startForeground()" when camera setup or UI work ran between the startForegroundService() call and the eventual startForeground() invocation, blowing past Android's foreground-service deadline. Promote the service during the init command, before any of the slow camera/rendering setup, so the deadline is satisfied unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a recording could ANR with "Context.startForegroundService() did not then call Service.startForeground()" when camera setup or UI work ran between the startForegroundService() call and the eventual startForeground() invocation, blowing past Android's foreground-service deadline.
Promote the service during the init command, before any of the slow camera/rendering setup, so the deadline is satisfied unconditionally.
Code changes by Claude Opus running inside Pi.dev. I built and tested this commit, it works fine in my phone.
Depends on #158 to build and run.