ux: start video recording on tap without opening the prep sheet#159
Open
cizra wants to merge 1 commit into
Open
ux: start video recording on tap without opening the prep sheet#159cizra wants to merge 1 commit into
cizra wants to merge 1 commit into
Conversation
The main button advertised long-press for configuration, but a normal tap still opened the preparation sheet whenever a required permission was missing, which is the common first-run state. For a dashcam-style flow tap should just start recording. Tap now requests the required permissions (camera, storage if needed) and starts with the saved defaults; long-press remains the explicit path to the preparation sheet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main button advertised long-press for configuration, but a normal tap still opened the preparation sheet whenever a required permission was missing, which is the common first-run state. For a dashcam-style flow tap should just start recording.
Tap now requests the required permissions (camera, storage if needed) and starts with the saved defaults; long-press remains the explicit path to the preparation sheet.
Code changes by Claude Opus running inside Pi.dev. I built and tested this commit, it works fine in my phone.
Depends on #158 to build and run.