Disable the libva GLX backend if EGL is enabled #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I've left the last two items unchecked on purpose as I think this might not be the solution that will be accepted. But we will see how you guys feel.
Currently mythtv always seem to pull in the
drmandglxbackend for libva.On Gentoo we have removed the glx backend for libva to simplify some packaging.
This shouldn't regress the user experience as it seems all packages using libva in Gentoo (including mythtv) also supports the EGL backend and usually prefers to use the EGL backend as well.
However there is currently no way to compile mythtv without also requiring the libva glx backend, even if it will never be used. So to fix this I created the "lazy" solution of making the GLX backend only available if EGL support is not turned on.
I'm unsure if this is an acceptable solution or not. But at least it should provide a good basis for starting a discussion.
One could instead for example add a
USING_GLXflag to allow both backends to be available as before.However most other projects that depend on libva in the Gentoo package manager seem to have opted to drop the GLX backend and always use the drm backend. (However this of course means that you won't be able to use it on older linux dists where EGL is not available)