feat(contract): add a burn function to destroy unused old sites #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had forgot to fix this one. The test should fail since at least one range bound should have been defined.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #291 will not alter performanceComparing Summary
|
giac-mysten
reviewed
Nov 11, 2024
| @@ -202,4 +202,15 @@ module walrus_site::site { | |||
| let routes = df::borrow_mut(&mut site.id, ROUTES_FIELD); | |||
| routes_remove(routes, route) | |||
| } | |||
|
|
|||
| /// Deletes a site object. | |||
There was a problem hiding this comment.
Question: Can we expose a function to delete everything?
There was a problem hiding this comment.
Everything meaning the dynamic fields? I looked into it, and I couldn't find a way to get all the dynamic fields on the contract level. 😬 So this seems to be unavoidable. Related thread: https://mysten-labs.slack.com/archives/C068VUPSG02/p1730982934293609.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_new_range_no_bounds_definedshould fail since at least one range bound should have been defined.The
site-builderwill be updated when there will also be adeleteargument support where both the blobs on walrus and the sui objects of a site will be deleted.Warning: The burn function should be called after the
site-builderhas deleted all dynamic fields (resources and routes) attached to the site! Otherwise, deleting an object that has dynamic fields still defined on it renders them all inaccessible to future transactions!