WIP Pricing Module #191
WIP Pricing Module #191
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/renewal/sources/renew.move
Outdated
| @@ -43,8 +43,8 @@ public struct NameRenewed has copy, drop { | |||
| } | |||
|
|
|||
| /// The renewal's package configuration. | |||
| public struct RenewalConfig has store, drop { | |||
| config: Config, | |||
| public struct RenewalConfig<phantom T> has store, drop { | |||
There was a problem hiding this comment.
Can we expose the Renewal<T> struct from the suins::pricing module instead? Also a "new" constructor as well as an immutable access to PricingConfig?
That'll make it easier for any higher-level (external) package to provide discounts etc for both registrations and renewals (direct reading from get_config<Renewal<SUI>>.config().calculate_price())
|
Let's only include core package changes in this PR! |
| 200 * suins::constants::mist_per_sui(), | ||
| 50 * suins::constants::mist_per_sui(), | ||
| ), | ||
| let range1 = new_range(vector[3, 3]); |
There was a problem hiding this comment.
I'd ideally keep the old config too, so the previous config tests also work for now.
No description provided.