Add total supply function #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwill
reviewed
Sep 29, 2024
crates/sui-graphql-client/src/lib.rs
Outdated
Comment on lines
213
to
338
| /// Get total supply for the coin type. | ||
| pub async fn total_supply(&self, coin_type: &str) -> Result<Option<u64>, Error> { | ||
| let coin_metadata = self.coin_metadata(coin_type).await?; | ||
|
|
||
| coin_metadata | ||
| .map(|c| c.supply) | ||
| .flatten() | ||
| .map(|c| c.try_into()) | ||
| .transpose() | ||
| } |
There was a problem hiding this comment.
why don't we just have a single "get_coin_metadata" function that has all the metadata info vs one that just gets total supply?
There was a problem hiding this comment.
we have that, this was more of a convenience method replicating what we used to have in the old sdk + json rpc
stefan-mysten
force-pushed
the
add_total_supply
branch
from
38a81f5
to
7056ed1
Compare
stefan-mysten
force-pushed
the
add_total_supply
branch
from
7056ed1
to
a9e99c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.