[REFACTOR]: TokenValidator와 TokenGenerator 추가로 TokenService 가독성 증대 및 패키지 경로 수정 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejineer
changed the title
hojinida
approved these changes
Aug 24, 2024
| lateinit var sut: TokenGenerator | ||
| val userId = "1234" | ||
|
|
||
| beforeTest { | ||
| jwtProperty = JwtProperty().apply { | ||
| accessToken = JwtProperty.TokenProperties().apply { | ||
| expiration = 10000 | ||
| secret = "lnp1ISIafo9E+U+xZ4xr0kaRGD5uNVCT1tiJ8gXmqWvp32L7JoXC9EjAy0z2F6NVSwrKLxbCkpzT+DZJazy3Pg==" | ||
| secret = | ||
| "lnp1ISIafo9E+U+xZ4xr0kaRGD5uNVCT1tiJ8gXmqWvp32L7JoXC9EjAy0z2F6NVSwrKLxbCkpzT+DZJazy3Pg==" |
There was a problem hiding this comment.
HS512 알고리즘을 적용하려면 어느 정도 길이의 key가 필요해서 무작위로 넣었습니다. 나중에 fixture로 빼서 refactoring할 예정입니다
There was a problem hiding this comment.
무작위가 아니라 저희 키값을 넣어놓으셨는데요 ;;
There was a problem hiding this comment.
자세히 보면 다릅니다. 자세히 보아야 아름다워요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More