Implement several major in ResultCategoryCard/#87 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahyuun
previously approved these changes
Apr 27, 2024
Comment on lines
+1
to
+14
| export const RESULT_CATEGORY = { | ||
| COMMON_CULTURE: 'COMMON_CULTURE', | ||
| CORE_CULTURE: 'CORE_CULTURE', | ||
| PRIMARY_MANDATORY_MAJOR: 'PRIMARY_MANDATORY_MAJOR', | ||
| PRIMARY_ELECTIVE_MAJOR: 'PRIMARY_ELECTIVE_MAJOR', | ||
| DUAL_MANDATORY_MAJOR: 'DUAL_MANDATORY_MAJOR', | ||
| DUAL_ELECTIVE_MAJOR: 'DUAL_ELECTIVE_MAJOR', | ||
| SUB_MAJOR: 'SUB_MAJOR', | ||
| PRIMARY_BASIC_ACADEMICAL_CULTURE: 'PRIMARY_BASIC_ACADEMICAL_CULTURE', | ||
| DUAL_BASIC_ACADEMICAL_CULTURE: 'DUAL_BASIC_ACADEMICAL_CULTURE', | ||
| NORMAL_CULTURE: 'NORMAL_CULTURE', | ||
| FREE_ELECTIVE: 'FREE_ELECTIVE', | ||
| CHAPEL: 'CHAPEL', | ||
| } as const; |
There was a problem hiding this comment.
단어 뜻을 알아도 바로 와닿지 않은 것들이 좀 있는 것 같아요 예를 들어 basic academical culture,,,
주석으로 의미를 써주면 더 좋을 것 같아요!
There was a problem hiding this comment.
하위에 RESULT_CATEGORY_KO를 통해 매칭되는 한글의미를 확인할 수 있습니다.
DUAL은 복수전공을 의미하고 SUB은 부전공을 의미합니다.
| case DUAL_MANDATORY_MAJOR: | ||
| case DUAL_ELECTIVE_MAJOR: | ||
| case DUAL_BASIC_ACADEMICAL_CULTURE: | ||
| return <Button label="복수전공" variant="outlined" size="xs" />; |
There was a problem hiding this comment.
UI가 button과 같아 버튼 태그를 사용하게 되었는데, 버튼의 역할을 하지않다는 문제가 있네요. 시멘틱하게 사용하기 위해 role="presentation", role="none" cursor style변경의 기입를 추가하겠습니다
| @@ -10,7 +10,7 @@ const meta = { | |||
| docs: { | |||
| description: { | |||
| component: ` | |||
| - variant값으로 "primary" | "secondary" | "text" | "delete" 중 하나를 선택할 수 있습니다.\n | |||
| - variant값으로 "primary" | "secondary" | "list" | "outlined" 중 하나를 선택할 수 있습니다.\n | |||
There was a problem hiding this comment.
- 'list'라는 네이밍을 사용한 이유가 있을까요?
There was a problem hiding this comment.
해당 네이밍은 기존에 존재하던 variant로 새롭게 추가 된 것이 아닙니다
outlined를 추가하며 함께 업데이트만 진행했어요 !
gahyuun
previously approved these changes
Apr 30, 2024
seonghunYang
previously approved these changes
Apr 30, 2024
seonghunYang
previously approved these changes
May 1, 2024
gahyuun
approved these changes
May 2, 2024
seonghunYang
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용