Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update authentication error messages for better clarity #147

Merged
merged 2 commits into from
Sep 21, 2024
Merged

fix: update authentication error messages for better clarity #147

merged 2 commits into from
Sep 21, 2024

Conversation

seonghunYang
Copy link
Collaborator

πŸ“Œ μž‘μ—… λ‚΄μš©

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • 둜그인 μ‹œλ„ μ‹œ, μ—λŸ¬ λ°”μš΄λ”λ¦¬λ‘œ λ„˜μ–΄κ°€λŠ” μ—λŸ¬ ν˜„μƒμ„ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€

@seonghunYang seonghunYang added the bug Something isn't working label Sep 16, 2024
@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-urjfmogfpc.chromatic.com/

yougyung
yougyung previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@yougyung yougyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€ !

yougyung
yougyung reviewed Sep 16, 2024
View reviewed changes
app/business/services/user/user.command.ts Outdated
message: error.message,
message: '아이디 λ˜λŠ” λΉ„λ°€λ²ˆν˜Έκ°€ μΌμΉ˜ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.',
};
} else if (error instanceof BadRequestError) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unauthorizederror와 ν•΄λ‹Ή μ—λŸ¬λŠ” μ–΄λ–€ μΌ€μ΄μŠ€μ— μ˜ν•΄ κ΅¬λΆ„λ˜μ–΄ λ°œμƒν•˜λ‚˜μš”?

Copy link
Member

@gahyuun gahyuun Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ œκ°€ ν…ŒμŠ€νŠΈν•΄λ΄€μ„λ•, 아이디가 μ‘΄μž¬ν• λ• UnauthorizedErrorλ₯Ό λ°œμƒμ‹œν‚€κ³  아이디가 μ‘΄μž¬ν•˜μ§€ μ•Šμ„λ• BadRequestError둜 λ„μš°λ„€μš”. UnauthorizedErrorμΌλ•Œλ‚˜ BadRequestError μΌλ•Œ λ‘˜λ‹€ μ—λŸ¬λ©”μ„Έμ§€λ₯Ό '아이디 λ˜λŠ” λΉ„λ°€λ²ˆν˜Έκ°€ μΌμΉ˜ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.' 둜 λ„μš°λ©΄ μ–΄λ–¨κΉŒμš”??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e11fe1d

@github-actions GitHub Actions
Copy link

πŸš€storybook: https://65ccb85d5afe55a024495bc0-hlckgxaxog.chromatic.com/

@seonghunYang seonghunYang merged commit 30e3d2e into main Sep 21, 2024
3 checks passed
@seonghunYang seonghunYang deleted the fix-login-error-message branch September 21, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yougyung yougyung yougyung approved these changes

@gahyuun gahyuun gahyuun approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seonghunYang @yougyung @gahyuun