Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer&router history/#104 #106

Merged
merged 8 commits into from
May 26, 2024
Merged

Drawer&router history/#104 #106

merged 8 commits into from
May 26, 2024

Conversation

yougyung
Copy link
Member

@yougyung yougyung commented May 16, 2024

📌 작업 내용

  • drawer close시 2번 close함수가 실행되는 문제 해결
    • Overlay의 click을 통해 toggle을 실행하여 drawer을 종료시키는 경우 DrawerPrimitive.Root의 onClose가 실행되어 2번의 toggle함수가 실행되는 것이 원인이었습니다. onRelease를 통해서 drawer을 내리는 경우와, Overlay의 onClick을 통해서 drawer을 종료시키는 경우를 분리하기 위해 onRelease로 수정을 진행함으로 해결했습니다.
  • 불필요한 코드 제거 및 단순 수정
  • result page내의 data fetching을 기존 fetch-> tanstack query 로 수정
    • fetchUserInfo, fetchCredits, fetchResultCategoryDetailInfo

@yougyung yougyung linked an issue May 16, 2024 that may be closed by this pull request
@yougyung yougyung self-assigned this May 16, 2024
Copy link

Copy link

Copy link
Member

@gahyuun gahyuun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 pr로 생긴 문제는 아닌 것 같지만 마이페이지에서 결과 페이지로 이동 후 과목 drawer를 띄워서 overlay를 클릭하면 마이페이지로 이동하네요 확인 부탁드립니다! drawer,modal 둘다 같은 현상이 발생합니다

seonghunYang
seonghunYang previously approved these changes May 18, 2024
Copy link

Copy link
Collaborator

@seonghunYang seonghunYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 수고하셨습니다

@yougyung yougyung merged commit 87f7562 into main May 26, 2024
3 checks passed
@yougyung yougyung deleted the drawer&router-history/#104 branch May 26, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drawer과 router History 관계성 파악
3 participants