-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drawer&router history/#104 #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahyuun
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번 pr로 생긴 문제는 아닌 것 같지만 마이페이지에서 결과 페이지로 이동 후 과목 drawer를 띄워서 overlay를 클릭하면 마이페이지로 이동하네요 확인 부탁드립니다! drawer,modal 둘다 같은 현상이 발생합니다
seonghunYang
previously approved these changes
May 18, 2024
seonghunYang
approved these changes
May 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 수고하셨습니다
gahyuun
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용
onClose
가 실행되어 2번의 toggle함수가 실행되는 것이 원인이었습니다. onRelease를 통해서 drawer을 내리는 경우와, Overlay의 onClick을 통해서 drawer을 종료시키는 경우를 분리하기 위해onRelease
로 수정을 진행함으로 해결했습니다.fetchUserInfo
,fetchCredits
,fetchResultCategoryDetailInfo