Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-38] 회원탈퇴 오류 수정 #278

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Conversation

5uhwann
Copy link
Member

@5uhwann 5uhwann commented Jun 30, 2024

Issue

Close #277

✅ 작업 내용

  • 회원 탈퇴시 user 테이블과 completed_credit 테이블의 외래키 제약 조건때문에 회원탈퇴 시 발생하는 오류를 수정하였습니다.
  • WitDrawUserService에서 회원정보 삭제 로직 전 user의 모든 completedCredit 삭제 로직 추가
  • DeleteCompletedCreditPort 구현
    • deleteAllCompletedCredits()

🤔 고민 했던 부분

🔊 도움이 필요한 부분!!

@5uhwann 5uhwann added 🐛 fix 정상적으로 동작하지 않는 부분 수정 D-0 labels Jun 30, 2024
@5uhwann 5uhwann self-assigned this Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (784eb0a) to head (d635edb).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #278      +/-   ##
=============================================
- Coverage      83.82%   83.75%   -0.07%     
  Complexity       569      569              
=============================================
  Files            151      152       +1     
  Lines           2244     2247       +3     
  Branches          79       79              
=============================================
+ Hits            1881     1882       +1     
- Misses           317      319       +2     
  Partials          46       46              
Files Coverage Δ
...lication/service/withdraw/WithDrawUserService.java 100.00% <100.00%> (ø)
...ure/persistence/DeletedCompletedCreditAdapter.java 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784eb0a...d635edb. Read the comment docs.

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인! 테스트코드 작성해야할듯

@5uhwann 5uhwann merged commit a87c889 into develop Jun 30, 2024
3 of 5 checks passed
@5uhwann 5uhwann deleted the fix/DEV-38-withdraw_error branch June 30, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-0 🐛 fix 정상적으로 동작하지 않는 부분 수정 size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEV-38] 회원탈퇴 오류
2 participants