[DEV-28] 커스텀 수강과목 수정 api 분리 생성 삭제 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5uhwann
reviewed
Apr 11, 2024
Comment on lines
28
to
30
| public void generateTakenLecture(@LoginUser Long userId, | ||
| @Valid @RequestBody GenerateTakenLectureRequest generateTakenLectureRequest) { | ||
| generateTakenLectureUseCase.generateTakenLecture(userId, generateTakenLectureRequest.getLectureId()); |
There was a problem hiding this comment.
컨트롤러 메서드 명을 더 명확하게 해주는 것이 좋을거 같습니다!
ex. addCustomizedTakenLecture
| } | ||
|
|
||
| @DeleteMapping("{taken-lecture-id}") |
There was a problem hiding this comment.
Suggested change
| @DeleteMapping("{taken-lecture-id}") | |
| @DeleteMapping("{takenLectureId}") |
| @UseCase | ||
| @Transactional | ||
| @RequiredArgsConstructor | ||
| public class DeleteTakenLectureServiceById implements DeleteTakenLectureUseCase { |
There was a problem hiding this comment.
Suggested change
| public class DeleteTakenLectureServiceById implements DeleteTakenLectureUseCase { | |
| public class DeleteTakenLectureService implements DeleteTakenLectureUseCase { |
| package com.plzgraduate.myongjigraduatebe.takenlecture.application.usecase.save; | ||
|
|
||
|
|
||
| public interface GenerateTakenLectureUseCase { |
There was a problem hiding this comment.
pdf 파싱으로 생성되는 TakenLecture 유스케이스와 구분할 수 있도록 행동을 명확하게 정의한 유스케이스명을 사용하는 것이 좋을거 같습니다!
| @@ -37,6 +39,7 @@ public class TakenLectureJpaEntity extends TimeBaseEntity { | |||
|
|
|||
| private Integer year; | |||
|
|
|||
| @Enumerated(EnumType.STRING) | |||
There was a problem hiding this comment.
해당 변경으로 인한 실제 운영디비의 값 변경에 대한 내용은 따로 문서화 부탁드립니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✅ 작업 내용
변경된 api 명세