[DEV-8] Apply Conventions #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #245 +/- ##
=============================================
- Coverage 85.00% 84.22% -0.78%
+ Complexity 499 479 -20
=============================================
Files 141 133 -8
Lines 1960 1883 -77
Branches 64 64
=============================================
- Hits 1666 1586 -80
Misses 261 261
- Partials 33 36 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hoya324
approved these changes
Mar 16, 2024
| @@ -17,8 +16,8 @@ public class TokenService implements TokenUseCase { | |||
|
|
|||
| private final FindRefreshTokenPort findRefreshTokenPort; | |||
| @Override | |||
| public AccessTokenResponse createNewToken(TokenCommand tokenCommand) { | |||
There was a problem hiding this comment.
[comment]
생성하는거면 command도 맞는거 같은데 따로 뺀 이유가 있을까요??
There was a problem hiding this comment.
지난번 정의한 컨벤션에 따르면 request dto의 경우 필드 개수가 3개까지는 dto 사용이 아닌 각각 파라미터로 넘기기로 했습니다!
| @@ -14,9 +14,15 @@ | |||
| @UseCase | |||
| @Transactional(readOnly = true) | |||
| @RequiredArgsConstructor | |||
| public class FindLecturesByLectureCodeService implements FindLecturesByLectureCodeUseCase { | |||
| // FindLecturesByLectureCodeService와 통합하는게 나아보임 | |||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Close #244
✅ 작업 내용
🤔 고민 했던 부분
🔊 도움이 필요한 부분!!