Skip to content

Commit

Permalink
refactor: 불필요 코드 삭제
Browse files Browse the repository at this point in the history
  • Loading branch information
5uhwann committed Apr 5, 2024
1 parent f3b6a6f commit 9a0e40d
Showing 1 changed file with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,23 @@ public void generateOrModifyCompletedCredit(User user, GraduationResult graduati
));

List<CompletedCredit> completedCreditModels = resultMap.keySet().stream()
.map(completedCredit -> createCompletedCreditModel(user, completedCredit, resultMap.get(completedCredit)))
.map(completedCredit -> createCompletedCreditModel(completedCredit, resultMap.get(completedCredit)))
.collect(Collectors.toList());

CompletedCredit chapelCompletedCreditModel = createChapelCompletedCreditModel(user, completedCredits,
CompletedCredit chapelCompletedCreditModel = createChapelCompletedCreditModel(completedCredits,
graduationResult);
CompletedCredit normalCultureCompletedCreditModel = createNormalCultureCompletedCreditModel(completedCredits,
graduationResult);
CompletedCredit freeElectiveCompletedCreditModel = createFreeElectiveCompletedCreditModel(completedCredits,
graduationResult);
CompletedCredit normalCultureCompletedCreditModel = createNormalCultureCompletedCreditModel(user,
completedCredits, graduationResult);
CompletedCredit freeElectiveCompletedCreditModel = createFreeElectiveCompletedCreditModel(user,
completedCredits, graduationResult);

ArrayList<CompletedCredit> allCompletedCreditModels = new ArrayList<>(completedCreditModels);
allCompletedCreditModels.addAll(
List.of(chapelCompletedCreditModel, normalCultureCompletedCreditModel, freeElectiveCompletedCreditModel));
generateOrModifyCompletedCreditPort.generateOrModifyCompletedCredits(user, allCompletedCreditModels);
}

private CompletedCredit createCompletedCreditModel(User user, DetailGraduationResult detailGraduationResult,
private CompletedCredit createCompletedCreditModel(DetailGraduationResult detailGraduationResult,
Optional<CompletedCredit> completedCredit) {
return CompletedCredit.builder()
.id(completedCredit.map(CompletedCredit::getId).orElse(null))
Expand All @@ -71,7 +71,7 @@ private CompletedCredit createCompletedCreditModel(User user, DetailGraduationRe
.build();
}

private CompletedCredit createChapelCompletedCreditModel(User user, List<CompletedCredit> completedCredits,
private CompletedCredit createChapelCompletedCreditModel(List<CompletedCredit> completedCredits,
GraduationResult graduationResult) {
return completedCredits.stream()
.filter(completedCredit -> completedCredit.getGraduationCategory() == CHAPEL)
Expand All @@ -87,7 +87,7 @@ private CompletedCredit createChapelCompletedCreditModel(User user, List<Complet
.graduationCategory(CHAPEL).build());
}

private CompletedCredit createNormalCultureCompletedCreditModel(User user, List<CompletedCredit> completedCredits,
private CompletedCredit createNormalCultureCompletedCreditModel(List<CompletedCredit> completedCredits,
GraduationResult graduationResult) {
return completedCredits.stream()
.filter(completedCredit -> completedCredit.getGraduationCategory() == NORMAL_CULTURE)
Expand All @@ -103,7 +103,7 @@ private CompletedCredit createNormalCultureCompletedCreditModel(User user, List<
.graduationCategory(NORMAL_CULTURE).build());
}

private CompletedCredit createFreeElectiveCompletedCreditModel(User user, List<CompletedCredit> completedCredits,
private CompletedCredit createFreeElectiveCompletedCreditModel(List<CompletedCredit> completedCredits,
GraduationResult graduationResult) {
return completedCredits.stream()
.filter(completedCredit -> completedCredit.getGraduationCategory() == FREE_ELECTIVE)
Expand Down

0 comments on commit 9a0e40d

Please sign in to comment.