-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add js build tool and demo page #1
base: master
Are you sure you want to change the base?
Conversation
Hi Alex @alexkrolick I love this!! Thank you, it's brilliant!
Okay, so here's the rub, relating to the lookup tables AND the current constants. We have "some stuff" going on in the lab that involves a slight change of constants and a bit on the lookup table. One of the things is to get things to "line up" better around 16px as that is the established standard for standard vision. But also am looking to see if the LUT can be simplified at all. Also the LUT as shown does not distinguish the spot reading from fluent reading... that's my fault, there are actually 5 LUTs, for different use cases, and I've tried to combine them into one which has probably only cause confusion.... The use cases are:
What I am thinking, to keep things simple, is just consider the top two fluent text types, and just lump them into one grid: export const apcaFluentGrid = [
["min", "min", "min", "min", "min", "min", "min", "min", "min"],
["min", "min", "min", "min", "min", "min", "min", "min", "min"],
["min", "min", "min", 95, 90, 85, 80, "min", "min"],
["min", "min", "min", 90, 85, 80, 75, "min", "min"],
["min", "min", 95, 75, 70, 65, 60, 55, "min"],
["min", "min", 90, 70, 65, 60, 55, 50, 45],
["min", 95, 85, 65, 60, 55, 50, 45, 40],
["min", 90, 75, 60, 55, 50, 45, 40, 35],
["min", 85, 70, 55, 50, 45, 40, 35, 30],
[90, 75, 60, 50, 45, 40, 35, 30, "max"],
[85, 70, 55, 45, 40, 35, 30, "max", "max"],
[75, 60, 50, 40, 35, 30, "max", "max", "max"],
[70, 55, 45, 35, 30, "max", "max", "max", "max"],
[60, 45, 40, 30, "max", "max", "max", "max", "max"],
]; And for now, I am thinking we should remove spot reading and non text things from the math for simplicity. Thank you again so much! Andy |
This maps roughly onto the WCAG AA 4.5:1 for body text and 3:1 for headlines and icons, which seems like a good alignment between the versions.
It's good to have guidance on contrast for icons. It sounds like the guidelines are about the same as headlines so they might be able be grouped together, as they are in WCAG 2. Regarding the lookup table - I am not sure I understand how to use it. Is it like this?
Side notes:
|
Hi Alex @alexkrolick
That was the general idea...
Probably good in the interim. There are some subtle differences that are on the "future study list" to explore. The processing of words (VFWA) and lexical is separate from object recognition... There are assumptions that they have different requirements, but the "degree" of difference is an unknown factor to be investigated.
The LUT is the minimums for a given use case, font size and weight. The table may be interpolated. Linear interpolation is permitted, always round up to nearest 0.5px for fonts under 24px and round up to next 1px for larger fonts.
Which is too small. 14px is a reasonable brickwall minimum. 16px is the assumed minimum, the target is an wx-height of no less than 8px, with an x-height of 10px being somewhat ideal. I need to revise this chart to some more recent research, but it's still instructive:
That is the idea... the LUTs are there during the research phase (when will we ever be done, LOL)... but yes, a parametric curve is the plan. Here are things that need to happen to make it a parametric curve:
|
How does "minimum for a given use case" translate to the guideline "75 Lc for body text"? Is there an implied font weight/size in the use case? I don't get it if the guideline is meant to be used independently of the lookup table or not. |
// ==ClosureCompiler== | ||
// @compilation_level SIMPLE_OPTIMIZATIONS | ||
// @output_file_name apca-w3-v.0.0.98g-4g.2.min.js | ||
// @code_url https://raw.githubusercontent.com/Myndex/apca-w3/master/src/apca-w3-v.0.0.98g-4g.2.js | ||
// ==/ClosureCompiler== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may get rid of these gcc configs now.
I'm looking for ESM version and found this PR. It looks great! |
That is REALLY cool... it looks like the contrast sensitivity chart, rotated 180degrees.... Am actually getting ready to push a new LUT, it's available as a tab delimited, or an array, in the main repo: https://github.com/Myndex/SAPC-APCA/blob/master/DATA/LUT-GseriesJan112021.js Thank you!!! |
Hey Alex @alexkrolick Firstly, I am really sorry it has taken this long to get to this pull request. In December I had literally just started working with npm and Node, and at the same time there was a lot going on for the last many months in terms of continued development. I've created a brand "BuildTools" and merged your PR into that branch, and then updated to the current master, and have started to rework things... Questions:
|
export * from 'colorparsley' // export everything from that module as if part of this module
export * as parse from 'colorparsley' // put everything from 'colorparsley' module in the 'parse' export of this module
|
Proposal This is a rough draft
dist/cjs
,dist/esm
,dist/umd
to support CommonJS, ESModules, and UMD (browser/script) usage.Screen.Recording.2021-12-11.at.11.09.31.PM.mov