Initial commit - 1st public release

Edited some remarks in code
MyLab-odyssey · Apr 20, 2018 · aab441a · aab441a
1 parent 025a9e0
commit aab441a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/ED4scan/ED4scan_PRN.ino b/ED4scan/ED4scan_PRN.ino
@@ -68,7 +68,6 @@ size_t getLength(const __FlashStringHelper *ifsh)
 void printWelcomeScreen() {
   byte vLength = strlen(version);
   PrintSPACER();
-  //Serial.println(F("--- ED Battery Management Diagnostics ---"));
   Serial.println(F("--- ED4 Smart CAN  --  EV Diagnostics ---"));
   Serial.print(F("--- v")); Serial.print(version);
   for (byte i = 0; i < (41 - 5 - vLength - 3); i++) {
@@ -512,7 +511,7 @@ void printTCUdata() {
 void printBMSall() {
   byte selected[BMSCOUNT];   //hold list for selected tasks
 
-  //Read CAN-Bus IDs related to BMS (sniff traffic)
+  //Read all CAN-Bus IDs related to BMS
   for (byte i = 0; i < BMSCOUNT; i++) {
     selected[i] = i;
   }

diff --git a/ED4scan/_BMS_ED4_dfs.h b/ED4scan/_BMS_ED4_dfs.h
@@ -27,7 +27,7 @@
 //Definitions for BMS
 #define DATALENGTH 126
 #define CELLCOUNT 96
-#define RAW_VOLTAGES 0           //!< Use RAW values or calc ADC offset voltage
+#define RAW_VOLTAGES 0           //!< Use RAW values or calc with ADC resolution 
 #define IQR_FACTOR 1.5           //!< Factor to define Outliners-Range, 1.5 for suspected outliners, 3 for definitive outliners
 
 char* const PROGMEM EVMODES[] ={"HV OFF", "slow CHG", "fast CHG", "HV ON"};
@@ -123,7 +123,7 @@ typedef struct {
   byte ProdYear;                 //!< year of battery production
 
   float SOC;                     //!< State of Charge, as displayed in dash (x/50)
-  byte SOCrecalState;            //!< State of SOC recal
+  byte SOCrecalState;            //!< State of SOC recal (experimental, tbd)
 
   byte fSOH;                     //!< Flag showing if degraded cells are found, or battery failiure present 
   byte SOH;                      //!< Battery State of Health in %