Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

chainId in nodes.js x888 currency is changed to 0 #1882

Open
wants to merge 1 commit into
base: mercury
Choose a base branch
from

Conversation

svetanto
Copy link
Contributor

@svetanto svetanto commented Jun 1, 2018

for Evgeny Odnolko

@ghost
Copy link

ghost commented Jun 1, 2018

@svetanto Did you checked that your chainid works on your network?

@svetanto
Copy link
Contributor Author

svetanto commented Jun 1, 2018 via email

@hackmod
Copy link
Contributor

hackmod commented Jun 2, 2018

where can i find x888 public git repo?

@svetanto
Copy link
Contributor Author

svetanto commented Jun 3, 2018 via email

@fxsecltd
Copy link

fxsecltd commented Jun 9, 2018

Correct working was checked via adding custom node with parameters, equal to x888 node parameters, except chainid (if chainid is 0, all requests have success responces, if chainid is 888 - write requests have 'invalid sender' responses).

@fxsecltd
Copy link

Why this request still not merged, maybe it has some issues? New release already gone, but pull request still not merged.

@hackmod
Copy link
Contributor

hackmod commented Jun 12, 2018

you can't set chainid as 0. Please see ethereum/go-ethereum#13847

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants