Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle no connection #1078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle no connection #1078

wants to merge 1 commit into from

Conversation

futurepaul
Copy link
Collaborator

if they go offline and the device can detect it we'll show them they're offline

https://capacitorjs.com/docs/apis/network

Screenshot 2024-04-18 at 4 15 24 PM

Copy link

cloudflare-workers-and-pages bot commented Apr 18, 2024

Deploying mutiny-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae16a88
Status: ✅  Deploy successful!
Preview URL: https://87d06e97.mutiny-web.pages.dev
Branch Preview URL: https://no-connection.mutiny-web.pages.dev

View logs

src/router.tsx Outdated
Comment on lines 129 to 131
<Match when={state.network_status?.connectionType === "none"}>
<NoConnection />
</Match>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be before setup_error. having no internet would likely be the cause of a setup error

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the first things that gets returned from the setup phase is the LNURL call not working

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you guys are agreeing or disagreeing here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreeing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay rebased and fixed

@TonyGiorgio
Copy link
Collaborator

I don't like this. It's very jarring. It's one thing if it's during the setup, but if there's a little disconnection while on the home screen, the whole screen converts and flashes back when the connection resumes. This is not a good experience for a blip in connection issues. You can do a little disconnection icon at the top or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants