Update ASM and other dependencies for JDK 19 compatibility #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@l0rinc thank you very much for your efforts! Now, after all that years, there are newer versions of the affected dependencies. May I ask you to adjust them in your PR and verify if it still works fine, especially with Java 21? |
|
I'm not working in this area anymore, please feel free to redo the changes in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #190
Related to MutabilityDetector/ClientOfMutabilityDetector#46
Should we update https://github.com/paplorinc/MutabilityDetector/blob/master/src/main/java/org/mutabilitydetector/asmoverride/AsmCompatibility.java#L26 to
Opcodes.ASM9as well?