Skip to content

🐞 Convert rects to integers before applying padding #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 14, 2025

Conversation

MrKai77
Copy link
Owner

@MrKai77 MrKai77 commented Apr 5, 2025

No description provided.

@MrKai77 MrKai77 added the Bug label Apr 5, 2025
@MrKai77 MrKai77 requested a review from Copilot April 5, 2025 03:28
@MrKai77 MrKai77 self-assigned this Apr 5, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

Loop/Window Management/WindowAction.swift:154

  • [nitpick] The variable 'bounds' is re-declared, shadowing the parameter 'bounds'. Consider renaming it to 'paddedBounds' to improve clarity.
var bounds: CGRect = getBounds(from: bounds, disablePadding: disablePadding, screen: screen)

@MrKai77 MrKai77 marked this pull request as ready for review April 14, 2025 02:49
@MrKai77 MrKai77 merged commit 856fb70 into develop Apr 14, 2025
1 check passed
@MrKai77 MrKai77 deleted the bottom-padding-fix branch April 14, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant