Output error message for provider failures #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=========================================
- Coverage 67.17% 67.1% -0.08%
=========================================
Files 111 111
Lines 8195 8204 +9
=========================================
Hits 5505 5505
- Misses 2690 2699 +9
Continue to review full report at Codecov.
|
pyoor
force-pushed
the
verbose-bz-error
branch
from
ce6856c
to
a62a6e2
Compare
choller
requested changes
Nov 13, 2019
| raise RuntimeError("Failed to create bug: %s", ret) | ||
| if ret.status_code != 200: | ||
| content = json.loads(ret.content) | ||
| raise BugzillaProviderException(content['message']) |
There was a problem hiding this comment.
We should probably try to handle more error cases here:
- The resulting JSON might miss the
message. ret.contentmight not even parse as JSON (if the server has a hickup and returns nothing or e.g. the hardhat page)
In both cases, this would cause a 500 again. Instead we should probably wrap these cases in a BugzillaProviderException as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, provider error messages are obscured by django request exceptions. This PR adds a ProviderExceptions class and returns error messages containing the provider response.