fix: drop extraneous kubectl installation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
changed the title
Cervator
reviewed
Oct 25, 2021
There was a problem hiding this comment.
I forgot why I included it. Taking it out simplifies things and avoids curl not being in the upstream image. I can get at a kubectl builder later if I run into the need again. Thanks 👍
With this and the quick --cleanup tag @BenjaminAmos pointed out this has built successfully and I've validated the jdk8 variant (via PR-pushed image published to DockerHub I might add!)
We could go further with cleaner auth, parallel, etc, but this works for now and we may not actually need to rebuild all that often :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it need to download a new kubectl? Seems to work better without.