Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHCR #12

Merged
merged 4 commits into from
Mar 8, 2024
Merged

GHCR #12

merged 4 commits into from
Mar 8, 2024

Conversation

crayolakat
Copy link

Description

StateVoices currently doesn't have GHCR set up on their GitHub organization, so the GH Action to build a Spoke Docker image fails.

Since MoveOn has their own separate branch, we should be pushing to our own GHCR anyway, not overwriting StateVoices every time we do a push on main.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@crayolakat crayolakat changed the title Kathy ghcr GHCR Mar 8, 2024
@codygordon codygordon self-requested a review March 8, 2024 21:11
@crayolakat crayolakat merged commit 816fd7d into main Mar 8, 2024
14 checks passed
@crayolakat crayolakat deleted the kathy-ghcr branch March 8, 2024 21:12
@@ -27,7 +27,7 @@ jobs:
uses: docker/metadata-action@v3
with:
images: |
ghcr.io/statevoicesnational/spoke
ghcr.io/moveonorg/moveon-spoke

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigating to ghcr.io/moveonorg/moveon-spoke I get a 404, but ghcr.io/moveonorg/spoke works – is that what it should be?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Pasting here for visibility to the open-source community]

The ghcr.io/moveonorg/moveon-spoke URL should exist once the branch is merged into main since the workflow is run when a push is made on the main branch. I had to create a new ghcr.io/moveonorg/moveon-spoke URL and could not longer push to the old ghcr.io/moveonorg/spoke URL (403 forbidden error). I believe it's because this MoveOnOrg/Spoke is actually a new forked repo from the StateVoicesNational/Spoke repo, so lost the permissions to push to ghcr.io/moveonorg/spoke

crayolakat added a commit that referenced this pull request Mar 8, 2024
This reverts commit 816fd7d, reversing
changes made to 9caf12b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants