Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes filter keep focus when hiding/showing sticky #1711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samgrrehder
Copy link

The filter doesn't update the focused element when showing or hiding the sticky header. This fixes it.

The filter doesn't change the focused element when showing or hiding the sticky header. This fixes it.
if (isVisible !== laststate) {
// make sure the focused filter stay focused after showing/hiding sticky
var $td = $(document.activeElement).closest('td'),
column = $td.parent().children().index($td);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for contributing and I'm sorry for taking so long to follow up on this PR!

Would you please change this to get the cell's index from the data-column attribute since the header may have a colspan which would mess up this calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants