1.7.8: Server restart when incomplete and postShutdownDelay #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Restart server when gen didn't complete:
During generation with big view-distances in Alpha versions it occured that the server would spontaneously shutdown BEFORE it completed the generation. Without this patch to generate a continuous chunk of land you'd need to restar the whole gen at least 2-5 times or make huge overlaps.
- add postShutdownDelay to wait between iterations
When closing the server process, Windows did not immediately return the occupied memory such that the next JVM process didn't have enough free RAM to reserve.
The solution is to delay the next run, but I'm not sure the
Thread.sleepI introduced really works as expected, looking at processes in ProcessExplorer didn't show it waited 2.5s :/ So if you can confirm working or help fix it, that'd be neat.Old features untouched - backwards compatible.
PS: Should've made the formatting fix into another commit.