Skip to content

Conversation

@RohanRusta21
Copy link

Hi @Epsirom @ljyou001 @Miss-you @stdrc @yihong0618 ,

This PR introduces a .devcontainer/devcontainer.json file to the repository, enabling a consistent, reproducible, and isolated development environment for all contributors. This configuration is designed to simplify onboarding, reduce "works on my machine" issues, and empower both individual developers and open-source teams to contribute efficiently.

Feel free to ping if any other enhancement required for this PR :)

Thanks,
Rohan

@yihong0618
Copy link
Contributor

Hi @Epsirom @ljyou001 @Miss-you @stdrc @yihong0618 ,

This PR introduces a .devcontainer/devcontainer.json file to the repository, enabling a consistent, reproducible, and isolated development environment for all contributors. This configuration is designed to simplify onboarding, reduce "works on my machine" issues, and empower both individual developers and open-source teams to contribute efficiently.

Feel free to ping if any other enhancement required for this PR :)

Thanks, Rohan

This kind of patch I wonder we'd better open an issue to disscuss either

@stdrc
Copy link
Collaborator

stdrc commented Nov 16, 2025

reduce "works on my machine" issues, and empower both individual developers and open-source teams to contribute efficiently

The problem is, have you really encountered this issue? If you run uv sync, the installed packages even ruff and pyright should be of the same version as mine.

@RohanRusta21
Copy link
Author

@stdrc , I raised this PR as an enhancement not for solving any existing open issue.

My simple intention for this dvcontainer is to streamline all development activities to have proper and same setup. Using devcontainers anyone can start development without wasting time for setting up the environment. Mantainer and reviewers can also take leverage of devcontainers for PR testing, as they can setup quickly and when they are done they just have to terminate the isolated containers in no time.

@stdrc
Copy link
Collaborator

stdrc commented Nov 16, 2025

@stdrc , I raised this PR as an enhancement not for solving any existing open issue.

My simple intention for this dvcontainer is to streamline all development activities to have proper and same setup. Using devcontainers anyone can start development without wasting time for setting up the environment. Mantainer and reviewers can also take leverage of devcontainers for PR testing, as they can setup quickly and when they are done they just have to terminate the isolated containers in no time.

IMO with uv it is already quite easy to setup an environment for development. Since the core maintainers (I and some colleagues) don't use dev container, this file will be soon out of maintenance after this PR gets merged. Thanks you though for this work. If you don't mind we can keep this open until we find it necessary.

@RohanRusta21
Copy link
Author

@stdrc , I raised this PR as an enhancement not for solving any existing open issue.

My simple intention for this dvcontainer is to streamline all development activities to have proper and same setup. Using devcontainers anyone can start development without wasting time for setting up the environment. Mantainer and reviewers can also take leverage of devcontainers for PR testing, as they can setup quickly and when they are done they just have to terminate the isolated containers in no time.

IMO with uv it is already quite easy to setup an environment for development. Since the core maintainers (I and some colleagues) don't use dev container, this file will be soon out of maintenance after this PR gets merged. Thanks you though for this work. If you don't mind we can keep this open until we find it necessary.

@stdrc sure boss now its totally upto to the maintainers of repo, actually i have seen devcontainers in many oss github repos so thats why I thought why not add here :)

@stdrc stdrc added the wontfix This will not be worked on label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants