add unit tests for runtime/core - scope #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziflex
requested changes
Oct 10, 2018
|
@ziflex, can you give the latest commit a review and see if that tests the scenario you were looking for? I just forked an existing scope that had a set variable and then ran some tests against the forked Scope. |
ziflex
reviewed
Oct 11, 2018
|
|
||
| func TestScope(t *testing.T) { | ||
| Convey("Should match", t, func() { | ||
| rs, cf := core.NewRootScope() |
There was a problem hiding this comment.
Looks good.
Let's do the final change.
RootScope - varA
Child1Scope - varB
Child2Scope - empty
Add a check that Child2Scope is able to get a variable from the root scope. (it will test functionality of scope traversing)
There was a problem hiding this comment.
You can just add it as a 2nd Convey suit.
There was a problem hiding this comment.
I think the new TestScopeTraversing should cover this situation, let me know your thoughts :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for runtime/core per issue #34.