Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add unit tests for runtime/core #41

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

esell
Copy link
Contributor

@esell esell commented Oct 4, 2018

Currently work in progress

This PR adds unit tests for runtime/core per issue #34.

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you format the code with gofmt before committing the code?
You can just do it by running make fmt.

import (
"testing"

"github.com/esell/ferret/pkg/runtime/core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can clone your fork using project's original path. In this case, you won't need to deal with paths.

@esell
Copy link
Contributor Author

esell commented Oct 4, 2018

@ziflex, thanks for giving this a once over. The gofmt thing is odd as my editor runs that on save. I just manually ran the file through gofmt and it spit out the same thing...

I'll keep hacking away on the other stuff and make sure it's all formatted before being pushed.

@ziflex
Copy link
Member

ziflex commented Oct 4, 2018

@esell ok, my bad. looks like GitHub displays the code differently, so I thought you didn't format it.
Now I checked with existing files - same formatting.

@ziflex ziflex merged commit 71ee1f3 into MontFerret:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants