Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for runtime/expressions - param #145

Merged
merged 2 commits into from
Oct 28, 2018
Merged

add unit tests for runtime/expressions - param #145

merged 2 commits into from
Oct 28, 2018

Conversation

agneum
Copy link
Contributor

@agneum agneum commented Oct 27, 2018

Issue #34

ziflex
ziflex requested changes Oct 27, 2018
View reviewed changes
Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is one thing I would like to change.
It seems I missed it in previous PRs. My bad.
Could you rename "Should match" descriptions to something more accurate and meaningful?

@agneum
Copy link
Contributor Author

agneum commented Oct 28, 2018

Fixed

ziflex
ziflex approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now much better! Thanks!

@ziflex ziflex merged commit c25b8e3 into MontFerret:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziflex ziflex ziflex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agneum @ziflex