-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for runtime/core - value #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there is one thing I would like to change.
It seems I missed it in previous PRs. My bad.
Could you rename "Should match" descriptions to something more accurate and meaningful?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
Thank you for your PR! |
@agneum so glad you took care of this :). Work got in the way and my OCD was killing me that there was one file left to write tests for haha. |
Issue #34