Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for runtime/core - value #144

Merged
merged 2 commits into from
Oct 28, 2018

Conversation

agneum
Copy link
Contributor

@agneum agneum commented Oct 27, 2018

Issue #34

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is one thing I would like to change.
It seems I missed it in previous PRs. My bad.
Could you rename "Should match" descriptions to something more accurate and meaningful?

@agneum
Copy link
Contributor Author

agneum commented Oct 28, 2018

Done.

Copy link
Member

@ziflex ziflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@ziflex
Copy link
Member

ziflex commented Oct 28, 2018

Thank you for your PR!

@ziflex ziflex merged commit 7da10c5 into MontFerret:master Oct 28, 2018
@esell
Copy link
Contributor

esell commented Oct 29, 2018

@agneum so glad you took care of this :). Work got in the way and my OCD was killing me that there was one file left to write tests for haha.

3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants