Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows installation #230

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix windows installation #230

merged 2 commits into from
Jan 30, 2025

Conversation

vydrazde
Copy link
Contributor

Description

Fixes

  • using commands not available in cmd.exe
  • condition for installation to not fail when check for determining the installed version fails

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

Tested manually on Windows Server 2019

@vydrazde vydrazde force-pushed the fix/windows-install branch from 75ca7de to 617210a Compare January 16, 2025 14:09
MonolithProjects
MonolithProjects approved these changes Jan 30, 2025
View reviewed changes
Copy link
Owner

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@MonolithProjects MonolithProjects added the bug Something isn't working label Jan 30, 2025
@MonolithProjects MonolithProjects merged commit c7ced19 into MonolithProjects:master Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vydrazde @MonolithProjects