Log Content Builder command before execution#47
Open
marko1olo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
The Content Builder templates currently print
Content Builder started, but the generated MSBuild target does not show the command line that is about to be executed. This adds a high-importance MSBuildMessageimmediately before theExectask in all three generatedBuildContent.targetsfiles, using the same$(ContentCommand) $(ContentArgs)expression that theExectask runs.Validation:
.targetsfiles as XML.git diff --checkpassed.dotnet pack CSharp\MonoGame.Templates.CSharp.csproj -p:Configuration=Release /p:Version=3.8.5passed.mgblankmgcbstartkitintoC:\tmp\mgtemplates-39-smoke\CommandMessageGame.CommandMessageGame.Content\BuildContent.targetscontains the newMessagetask.CommandMessageGame.DesktopGL.csprojwithDOTNET_ROLL_FORWARD=Major; build succeeded and printed the generated Content Builder command line before[I] Starting Content Builder.AI-assisted contribution: implementation and verification were performed with OpenAI Codex under my direction.