Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csse pyd2 modernize compute function #455

Open
wants to merge 7 commits into
base: next2024
Choose a base branch
from

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Oct 3, 2024

currently atop #454

Description

  • reworks the compute fns and user interface to handle multiple schema versions. this replaces some of checkver_and_convert's responsibilities
  • see also the changelog

Changelog description

Status

  • Code base linted
  • Ready to go

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 92.15292% with 78 lines in your changes missing coverage. Please review.

Project coverage is 81.58%. Comparing base (0642655) to head (44ac0a6).
Report is 3 commits behind head on next2024.

Additional details and impacted files

more tests

fix import and checks

fix typo

try xtb

xtb and mrchem

sdftd3

more tests

few fixes?

test_programs

all but stdsuite

stdsuite

fix alignment tests

docker and prop

docker

docker2

docker3

docker4

docker5

docker6

docker7

docker8

back and np fixed

tidy up
@loriab loriab force-pushed the csse_pyd2_506d branch 2 times, most recently from 5fe7b3b to 05bac88 Compare October 6, 2024 19:59
@loriab loriab marked this pull request as ready for review October 6, 2024 20:55
@loriab loriab changed the title Csse pyd2 506d Csse pyd2 modernize compute function Oct 6, 2024
@loriab loriab mentioned this pull request Oct 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant