Csse pyd2 502 #345
Merged
Csse pyd2 502 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As one can't request a review by the usual means outside the MolSSI GH org, here's a ping instead, @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131 |
davidbrownell
approved these changes
Sep 4, 2024
| @@ -62,7 +62,7 @@ database. | |||
|
|
|||
| >>> mol = qcel.models.Molecule(**{"symbols": ["He", "He"], "geometry": [0, 0, -3, 0, 0, 3]}) | |||
| >>> mol.get_hash() | |||
| '84872f975d19aafa62b188b40fbadaf26a3b1f84' | |||
| '84872f975d19aafa62b188b40fbadaf26a3b1f84' # pragma: allowlist secret | |||
There was a problem hiding this comment.
Is this a secret or a hash? Consider changing the comment if necessary.
There was a problem hiding this comment.
It's a hash, but I'm not seeing any flexibility in the signaling syntax to describe it more accurately. https://github.com/Yelp/detect-secrets/blob/master/README.md#inline-allowlisting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modelstomodels.v1and adjust imports so everything remains in working order.next2024which is presently nearly even withmaster.Changelog description
Status