Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trigger onProgressChanged on non-user interaction. #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not trigger onProgressChanged on non-user interaction. #12

wants to merge 2 commits into from

Conversation

JarmoKukkola
Copy link

In my opinion, the onProgressChanged should not be triggered, when user is not interacting with the widget.

Jarmo Kukkola added 2 commits November 1, 2020 09:24
Do not trigger onProgressChanged on non-user interaction.
7af3619
Removed string.xml from seekbar library. This could potentially chang…
9b92aee 
…e the name of any app that the library is included with (the file has only app_name value).
@MohammedAlaaMorsi
Copy link
Owner

Hi @JarmoKukkola , Thanks for your contribution, yes removing the app_name from strings is a good thing, regarding onProgressChanged there was a previous issue with this , as if you need to listen to the change in progress value, if we removed the call to onProgressChanged you can't get the values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JarmoKukkola @MohammedAlaaMorsi