add condition for wasm toolchain selection#351
Closed
JimZhouZZY wants to merge 1 commit into
Closed
Conversation
Author
|
关闭了 PR，因为找不到好的方法获取是否已经配置 toolchain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
给 wasm 平台下的 set_toolchain() 调用添加 not has_config("toolchain") 条件判断。
Why?
当前构建脚本在 lolly 作为依赖包参与构建时，仍会切换 toolchain。然而，作为依赖包时，其 toolchain 应当继承自父项目，以保证整个依赖链条使用一致的构建环境。
因此增加该条件判断：当 toolchain 已经由上层项目指定时，不再覆盖现有配置；仅在未指定 toolchain 的情况下使用默认设置。