Skip to content

Commit

Permalink
Apply fixes from StyleCI
Browse files Browse the repository at this point in the history
  • Loading branch information
Modelizer authored and StyleCIBot committed Apr 4, 2018
1 parent 3dfcd00 commit 87c4678
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 14 deletions.
8 changes: 4 additions & 4 deletions bootstrap/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@
'mac' => [
'version' => 'v0.20.0',
'url' => 'https://github.com/mozilla/geckodriver/releases/download/v0.20.0/geckodriver-v0.20.0-macos.tar.gz',
'filename' => 'geckodriver'
'filename' => 'geckodriver',
],

'win' => [
'version' => 'v0.20.0',
'url' => 'https://github.com/mozilla/geckodriver/releases/download/v0.20.0/geckodriver-v0.20.0-win32.zip',
'filename' => 'geckodriver.exe'
'filename' => 'geckodriver.exe',
],
'linux' => [
'version' => 'v0.20.0',
'url' => 'https://github.com/mozilla/geckodriver/releases/download/v0.20.0/geckodriver-v0.20.0-linux32.tar.gz',
'filename' => 'geckodriver'
]
'filename' => 'geckodriver',
],
],
],

Expand Down
11 changes: 6 additions & 5 deletions src/Console/BootSelenium.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ class BootSelenium extends Command
use WebDriverUtilsTrait;

/**
* DWebDriver name to be use
* DWebDriver name to be use.
*
* @var array
*/
protected $dWebDriver = [
'chrome' => 'chrome',
'firefox' => 'gecko',
'edge' => 'edge'
'edge' => 'edge',
];

/**
Expand Down Expand Up @@ -51,20 +52,20 @@ public function handle()
}

/**
* Get the default commands which are require to boot selenium server
* Get the default commands which are require to boot selenium server.
*
* @return array
*/
public function getSeleniumDefaultCommand()
{
return [
return [
'java',
$this->getWebDriver(env('DEFAULT_BROWSER', $this->argument('driver'))),
'-jar '.$this->getSeleniumServerQualifiedName(),
'-enablePassThrough false',
];
}


/**
* Get selenium server qualified location.
*
Expand Down
2 changes: 1 addition & 1 deletion src/Console/Kernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ class Kernel extends OrchestraKernel
protected $commands = [
BootSelenium::class,
GetWebDriver::class,
ServeCommand::class
ServeCommand::class,
];
}
1 change: 1 addition & 0 deletions src/Services/InteractWithPage.php
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ protected function wait($seconds = 1)
* Alias for wait.
*
* @param int $seconds
*
* @return TestCase
*/
protected function hold($seconds = 1)
Expand Down
2 changes: 2 additions & 0 deletions src/Services/ManageWindow.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ trait ManageWindow
*
* @param int $width
* @param int $height
*
* @return $this
*/
public function changeWindowSize(int $width = 1024, int $height = 768)
Expand All @@ -30,6 +31,7 @@ public function changeWindowSize(int $width = 1024, int $height = 768)
* Set the current window's width.
*
* @param $width
*
* @return \Facebook\WebDriver\WebDriverWindow
*/
public function setWidth($width)
Expand Down
8 changes: 4 additions & 4 deletions tests/feature/FormTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ public function it_should_type_by_css_selector()
public function it_should_type_information_and_press_a_button()
{
$formInfo = [
'firstName' => 'Mohammed',
'lastName' => 'Mudassir',
'firstName' => 'Mohammed',
'lastName' => 'Mudassir',
'inputEmail-name' => '[email protected]',
];

Expand All @@ -78,8 +78,8 @@ public function it_should_type_information_and_press_a_button()
public function it_should_submit_form()
{
$formInfo = [
'firstName' => 'Mohammed',
'lastName' => 'Mudassir',
'firstName' => 'Mohammed',
'lastName' => 'Mudassir',
'inputEmail-name' => '[email protected]',
];

Expand Down

0 comments on commit 87c4678

Please sign in to comment.