add novation-launchpad-s and apc40mkii description files #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFSaw
reviewed
May 15, 2025
| @@ -262,7 +262,7 @@ MIDIMKtlDevice : MKtlDevice { | |||
|
|
|||
| destination.notNil.if { | |||
| if ( thisProcess.platform.name == \linux ) { | |||
| midiOut = MIDIOut( 0 ); | |||
| midiOut = MIDIOut( 0, dstID ); | |||
There was a problem hiding this comment.
this is unrelated to the title of the PR, please explain why this is necessary and move into a separate PR
There was a problem hiding this comment.
Thanks for the feedback, you are right, i moved this commit to another pull request ^^
…ided" This reverts commit 7d769d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.