Migration to latest versions of torch & flash-attn to solve warmstart/fsdp2/weight tying problem #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses #381. The problem can be traced back to a bug in torch 2.6 related to the fact that we flatten the optimizer state dict here and here.
A solution is to simply migrate to torch 2.7. This requires to also migrate flash-attn to version 2.8.
This PR includes both migrations, along with minor adjustments of the warmstart config files.
Unit tests pass with github actions.
General Changes
Breaking Changes
Checklist before submitting final PR
python tests/tests.py
)CHANGELOG_DEV.md
)