WIP: Extended ini support #126
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that PR is very useful. Nobody has ever used the INI version of the game, so this is just adding complicated stuff to maintain for not much benefits. Non-developers do not understand half of the entry in the INI, so adding more is not very useful, actual developers can easily write an equivalent Python plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends ini support with optional:
[Features]LocalSavegames = True (defaults to game.savesDirectory()) or custom pathSaveGamePreview = path to img%SAVE_NAME%variable for e.g.%SAVE_NAME%.pngForceLoadLibraries = list of .dll files[BasicModDataChecker]and[BasicModDataChecker.move]ExtendedInterpolationto support e.h.{BasicGames.key}substitutionBasicGames.GameSaveAdditionalFilesas simple option forISaveGame.allFiles, with%SAVE_NAME%var*/*.exttoBasicModDataChecker(requires larger changes in another PR).inifile:game_template.iniThis would allow users without python knowledge to add a game support with some basic features or provide a good base for devs to add required functionality in python.