Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-4041] Sync project with onETL #8

Merged
merged 1 commit into from
May 15, 2023
Merged

[DOP-4041] Sync project with onETL #8

merged 1 commit into from
May 15, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented May 15, 2023

Sync project config files with onETL:

  • Fix ReadTheDocs failing builds
  • Remove useless .dockerignore (Docker is not used in this project)
  • Skip duplicating CI jobs while pushing commits to feature and bugfix branches
  • Skip running release workflows in forks
  • Run linters & CodeQL in parallel jobs
  • Combine coverage only after fetching all the coverage data
  • Set coverage target & threshold
  • Update pre-commit hooks
  • Add py.typed file to the repo to indicate that it can be checked by mypy as other project dependency
  • Remove duplicated badge for documentation
  • Replace documentation theme with furo instead of ReadTheDocs
  • Add sphinx_copybutton extension
  • Update flake8 and mypy configs, move .coveragerc to tests folder

@dolfinus dolfinus force-pushed the feature/DOP-4041 branch 4 times, most recently from 97aac1c to fb7611e Compare May 15, 2023 14:07
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #8 (8ec6e78) into develop (0afb249) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           43        43           
  Branches         4         4           
=========================================
  Hits            43        43           
Impacted Files Coverage Δ
evacuator/core.py 100.00% <100.00%> (ø)
evacuator/exception.py 100.00% <100.00%> (ø)

@dolfinus dolfinus force-pushed the feature/DOP-4041 branch 3 times, most recently from fd66435 to 87c84e1 Compare May 15, 2023 14:18
@dolfinus dolfinus self-assigned this May 15, 2023
@dolfinus dolfinus requested a review from Anna932 May 15, 2023 14:40
@dolfinus dolfinus enabled auto-merge (rebase) May 15, 2023 14:46
@dolfinus dolfinus merged commit 92652a4 into develop May 15, 2023
@dolfinus dolfinus deleted the feature/DOP-4041 branch May 15, 2023 14:48
#!/usr/bin/env bash

_term() {
echo "Caught SIGTERM signal!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo "Caught SIGTERM signal !"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А в чем разница?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants