Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_train_with_targets_for_reranker method #244

Open
wants to merge 20 commits into
base: experimental/two_stage
Choose a base branch
from
Open

Fix get_train_with_targets_for_reranker method #244

wants to merge 20 commits into from

Conversation

olesyabulgakova
Copy link
Collaborator

We make changes to the get_train_with_targets_for_reranker method to separate the retrieval of sampled candidates and unsampled candidates from first-stage candidate generators for the reranker.

@olesyabulgakova olesyabulgakova self-assigned this Jan 15, 2025
In48semenov
In48semenov reviewed Jan 29, 2025
View reviewed changes
olesyabulgakova and others added 10 commits January 30, 2025 11:54
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
6903941 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
531d642 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
d14c4ed 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
8b70b08 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
f6b1f9e 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/catboost_reranker.py
5700343 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
423c6a9 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova @In48semenov
Update rectools/models/ranking/candidate_ranking.py
b48aadf 
Co-authored-by: Andrey Semenov <[email protected]>
@olesyabulgakova
fix test_catboost_reranker.py
d5f7426
@olesyabulgakova
Merge branch 'experimental/two_stage' of https://github.com/olesyabul…
8325272 
…gakova/RecTools into experimental/two_stage
feldlime
feldlime reviewed Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@feldlime feldlime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these mistakes everywhere

@blondered
Copy link
Collaborator

Fixing tests on python 3.12:
rectools-lightfm = {version = "^1.17.3", optional = true} in pyproject.toml like here: https://github.com/MobileTeleSystems/RecTools/blob/main/pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@In48semenov In48semenov In48semenov left review comments

@blondered blondered Awaiting requested review from blondered

@feldlime feldlime Awaiting requested review from feldlime

Assignees

@olesyabulgakova olesyabulgakova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olesyabulgakova @blondered @feldlime @In48semenov