-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode log data to ascii string using c string pointer #217
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Konstantin Iurrichev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this pull request <3
I've been testing the changes on one of personal projects and can confirm it's working as expected - I can get the activity log parsed correctly.
Prior to these changes, I've been getting an error complaining about incorrect activity log file. See #219 for more details.
Can we please make the CI checks green? 🙏
Other than that, let's ship it
Any reason why this one's not getting attention? does seem like the fix needed. |
@polac24 @ecamacho @CognitiveDisson Waiting for your approve 🙏 |
There are some linting issues 👀 |
Co-authored-by: Daeho Ro <[email protected]> Signed-off-by: memoto <[email protected]>
@daeho-ro Thanks for suggestion that has fixed the linting! |
@aleksandergrzyb Your stale review were dismissed due to lint fix, could you please approve again? |
Swift 6 String's
init?(data: Data, encoding: String.Encoding)
fails validation during encodingutf8
data toascii
and returnsnil
.As proposed solution we inspect memory buffer bound to
UInt8/CChar
bytes, assuming they are null-terminted which allows us to produce a new string by simply copying them and interpreting asascii
.