Replace Foundation scanner implementation #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcmramos-bumble
requested review from
polac24,
ecamacho,
aleksandergrzyb and
CognitiveDisson
as code owners
jrcmramos-bumble
changed the title
Signed-off-by: Jose Ramos <[email protected]>
Signed-off-by: Jose Ramos <[email protected]>
Signed-off-by: Jose Ramos <[email protected]>
Signed-off-by: Jose Ramos <[email protected]>
Signed-off-by: Jose Ramos <[email protected]>
jrcmramos-bumble
force-pushed
the
replace-scanner-with-substrings
branch
from
2b0b5ef to
740d31b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #215.
The memory leak is not
XCLogParserimplementation related, but instead associated with theScannerobject while parsing considerable large files (tested with 243.3MB logs).The initial attempt replaced
ScannerwithSubstrings(please check commit history). Due to the poor runtime performance, mostly related with protocol witness calls to collection methods, we had to replace with a newScannercomponent, implementing a subset of methods for our usages. This new implementation avoids invoking non performanceStringrelated methods.Taking into account the above mentioned file, we were able to improve performance by around 80% compared to
masters implementation