Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connects to #358. Dependency updates and search UI refactoring. #359

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

jimmyzhen
Copy link
Contributor

Key Changes

Dependency updates (see #358 for more details):

  • Switched vis-network-react module source from no-longer-maintain repo to a forked repo containing upgraded version of vis-network library
  • Removed individually installed vis-network and vis-data modules since the forked vis-network-react module contains upgraded versions of these libraries
  • Converted JSON to JavaScript object for the PASS1B-06's network figure (4e) used on homepage since newer version of vis-network library supports html markup in tooltip
  • Removed console.log callback handlers from prior vis-network-react implementation

Search UI refactoring:

  • The React component responsible for rendering the radio buttons for selecting either gene, protein id, or metabolite names on the Search page contains repetitive JSX markup and produces unreliable interactive behavior
  • This component has been converted into reusable child components with a parent component.

@jyu-sm
Copy link
Collaborator

jyu-sm commented Jun 28, 2024

lgtm

@jimmyzhen jimmyzhen merged commit 0d0d4ce into dev Jun 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage update of vis-network-react dependency
3 participants